Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram for code layouts in safer ffi #107

Open
wants to merge 11 commits into
base: ditto-node-js
Choose a base branch
from
Open

Diagram for code layouts in safer ffi #107

wants to merge 11 commits into from

Conversation

ronan-ditto
Copy link
Contributor

Diagrams to help future developers understand what is going one.

@danielhenrymantilla
Copy link
Collaborator

Yeah, adding diagrams will be quite useful, thanks for kickstarting it! 👌

  • (I think we'll have to wait a bit until the design is fully polished, though; for instance, the LegacyCType is just a trait to help me write the transition to the new CType trait: it is expected to be removed once completed)

@ronan-ditto
Copy link
Contributor Author

I'll update it when needed, just let me know if there is any change.

@danielhenrymantilla danielhenrymantilla force-pushed the cleanup-replace-macro-rules-with-proc-macros branch 3 times, most recently from 3918d05 to b22bd95 Compare May 18, 2022 20:19
@danielhenrymantilla danielhenrymantilla force-pushed the cleanup-replace-macro-rules-with-proc-macros branch 2 times, most recently from 7f515a9 to 64cd908 Compare June 28, 2022 17:23
Base automatically changed from cleanup-replace-macro-rules-with-proc-macros to ffi-safe-dyn-traits June 29, 2022 14:30
Base automatically changed from ffi-safe-dyn-traits to ditto-node-js June 29, 2022 14:45
@bigfish24
Copy link

@ronan-ditto were you planning to merge this?

@ronan-ditto
Copy link
Contributor Author

I need to update this this Daniel latest changes I think before merging

@steph-lui steph-lui added 2023-Q3 and removed 2023-Q2 labels Jul 5, 2023
@steph-lui steph-lui removed the 2023-Q3 label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhenrymantilla danielhenrymantilla danielhenrymantilla approved these changes

Assignees

@ronan-ditto ronan-ditto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronan-ditto @danielhenrymantilla @bigfish24 @steph-lui