Add <formula-editor /> component #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-server Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
literalEval
changed the title
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
| @@ -0,0 +1,62 @@ | |||
| export class Stack<Type> { | |||
| private _inner: Type[] = []; | |||
There was a problem hiding this comment.
inner can be named more descriptively
similarly for Queue
| return this._inner.at(-1); | ||
| } | ||
|
|
||
| empty(): boolean { |
| export enum Expectation { | ||
| VARIABLE, | ||
| OPERATOR, | ||
| UNDEF, |
| @@ -0,0 +1,127 @@ | |||
| export class Recommender { | |||
| private _trie: TrieNode; | |||
| private _minSuggestionLen: number; | |||
There was a problem hiding this comment.
_minSuggestionLen -> _mininumSuggestionLength
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
…entation Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
| if (!editor) return; | ||
|
|
||
| this.parseInput(recommendation); | ||
| this.currentCursorPosition = null; |
| return false; | ||
| } | ||
|
|
||
| static getCaret = (element: any) => { |
There was a problem hiding this comment.
getCaret -> getCaretPosition
similarly for setCaret
| this.currentCursorPosition = null; | ||
| } | ||
|
|
||
| parseInput(addRecommendation: string | null = null) { |
There was a problem hiding this comment.
addRecommendation -> recommendation
|
|
||
| this._calculatedResult = calculatedResult ?? NaN; | ||
| this._errorStr = | ||
| calculatedResult == undefined |
There was a problem hiding this comment.
condition doesn't seem intuitive
| ></suggestion-menu>` | ||
| : html``} | ||
| <div id="wysiwyg-err" class="${this._errorStr ?? "wysiwyg-no-err"}"> | ||
| ${this._errorStr ?? "No Errors"} |
There was a problem hiding this comment.
can choose to show \n instead of "No Errors"
There was a problem hiding this comment.
Newlines are treated the same as spaces, so I am changing to no breaking space instead.
There was a problem hiding this comment.
can consider to move these functions to helpers.ts
Signed-off-by: Ravi Dev Pandey <[email protected]>
| tokens.forEach((token) => { | ||
| // It is a number is either it's in the defined variables, or | ||
| // it's a valid number literal. | ||
| let isNumber = this.variables.has(token) || !Number.isNaN(Number(token)), |
There was a problem hiding this comment.
how about using a tokenType=number | operator | bracket | space
instead of having 4 such variables.
There was a problem hiding this comment.
Actually I was thinking of having an Enum for this. Seemed like a more structured approach to me.
| } | ||
|
|
||
| const tokens = formula | ||
| .split(/([-+(),*^/:?\s])/g) |
There was a problem hiding this comment.
can have the delimiters defined as a const, to be used at multiple places
Signed-off-by: Ravi Dev Pandey <[email protected]>
Signed-off-by: Ravi Dev Pandey <[email protected]>
Isha-Sharma
force-pushed
the
main
branch
2 times, most recently
from
646a777
to
6f72838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
What is done ?
Possible bugs/Needs testing
-and+operators / Handling negative numbers.What remains ?