Feature: setting for equal height cards

[jdcmarques]

Proposed change

Forces every service in a row to be the same vertical size without removing any content.

Before

After

Desktop tested on chromium & firefox
Mobile on iOS Safari

Closes # (issue)

Type of change

• New service widget
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation only
• Other (please explain)

Checklist:

• If applicable, I have added corresponding documentation changes.
• If applicable, I have reviewed the feature and / or service widget guidelines.
• I have checked that all code style checks pass using pre-commit hooks and linting checks.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

[shamoon]

I appreciate that this has been requested #1922 #1570 but man, I find this aesthetically very un-pleasing. Thats subjective, of course, but at the very least this should be opt-in.

Please let us know if youre able to make that change.

[jdcmarques]

I appreciate that this has been requested #1922 #1570 but man, I find this aesthetically very un-pleasing. Thats subjective, of course, but at the very least this should be opt-in.

Please let us know if youre able to make that change.

Will do, will update PR once it's ready.
What would be the best config for this?

[shamoon]

You mean what to call it or where to put it? Good q. Maybe something like "useEqualHeights" or "equalHeights"? Name doesnt matter that much as long as its self-evident-ish, I think.

As for where, at the very least it should be a global setting (Im ok with just that) but there are some settings that can also be specified per-service such as hideErrors. That might be nice to have for this so you can either set it globally or per-group (or override the global setting on a per-group basis). I dont recall if we have anything like that for a group not just a service but same idea

[benphelps]

I agree with @shamoon here, in some cases it'd look worse, so opt-in. And from past experience, people really dislike their layout changing without asking for it, so best to leave that can closed.

It could be a global setting, and if you're up to it, a group setting as well.

useEqualHeights: true

layout:
  My Group:
    useEqualHeights: false

[jdcmarques]

Updated the PR with the useEqualHeights config.

Thanks for the feedback!

[shamoon]

Awesome, works great and thanks for the quick rework

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.