Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show recurring and multi-day events #2451

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

denispapec
Copy link
Contributor

Proposed change

This PR fixes issue where all recurring ical events aren't shown and multi-day events don't show instance for every day they're scheduled.

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As I’ve said, calendars are hard…

is the new dependency really necessary? It’s actually not that small, all things considered.

@denispapec
Copy link
Contributor Author

It does help a lot with having short and complete solution (and not adding new bugs in that logic ;) ).
I believe that this recurring rule logic really doesn't fit into this project, and should be handled by a tested package.

BTW rrule is already in the project (as cal-parser dependency), but I had to specify it considering that I'm accessing it directly in the code.

@shamoon shamoon enabled auto-merge (squash) December 10, 2023 15:16
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Hoping this is the last of the calendar PRs 🤞

@shamoon shamoon merged commit a72ccb6 into gethomepage:main Dec 10, 2023
2 checks passed
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
@denispapec denispapec deleted the recurringEvents branch May 5, 2024 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants