Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fritzbox error when response contains empty values #2463

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

evorg
Copy link
Contributor

@evorg evorg commented Dec 10, 2023

Proposed change

Make the fritzbox proxy more robust, that missing or empty properties does not result in an error.

Closes #2461

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon enabled auto-merge (squash) December 10, 2023 20:21
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ugly optional chaining but suppose thats what happens with xml

Thanks for the fast fix =)

@shamoon shamoon merged commit d38b313 into gethomepage:main Dec 10, 2023
2 checks passed
@evorg evorg mentioned this pull request Dec 12, 2023
9 tasks
@evorg evorg deleted the fix/issue-2461 branch December 13, 2023 09:04
Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] fritzbox proxy fails when no value returned in response
2 participants