-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: support instanceName
filtering for kubernetes auto-discovery deployment
#2488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This certainly looks like it would work but double-checking, did you actually test it?
instanceName
filtering for kubernetes deployment
Co-authored-by: shamoon <[email protected]>
You are too quick for me 😉 I have now done testing and can confirm it works. My testing was to build the image deploy on my cluster and see
I have tested it on vivaldi (chrome based) and firefox, but I would be shocked if this is browser based |
Ha, sorry about that—no rush, but looks good =) |
instanceName
filtering for kubernetes deploymentinstanceName
filtering for kubernetes auto-discovery deployment
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
Add another annotation to kubernetes discovery to allow user to specify for which instance is this supposed to be present for. If no instance provided then it works for all instances preserving current behaviour.
Closes #2487
Type of change
Checklist: