Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use viewable count if it exists #2492

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Use viewable count if it exists #2492

merged 1 commit into from
Dec 18, 2023

Conversation

HaveAGitGat
Copy link
Contributor

Proposed change

Use viewable count if it exists, which removes file count of any disabled libraries etc
Only shows items which are viewable in the tables in the UI.

If new data not available then use previous data.

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • [ x] Other (please explain)

Slight data change which fixes:

HaveAGitGat/Tdarr#932

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • [x ] I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose with respect to Tdarr, I should take your word on it =)

Thanks for the PR

@shamoon shamoon merged commit b9f1ddd into gethomepage:main Dec 18, 2023
2 checks passed
@HaveAGitGat
Copy link
Contributor Author

😂 ty for merge

Copy link
Contributor

github-actions bot commented Feb 5, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants