Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: corrections Beszel widget docs #4282

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Documentation: corrections Beszel widget docs #4282

merged 4 commits into from
Nov 12, 2024

Conversation

abey
Copy link
Contributor

@abey abey commented Nov 12, 2024 •
edited
Loading

Proposed change

Improved Beszel widget documentation. Specifically:

  • Fixed Beszel repository link
  • Added information about where to find systemId
  • Added information about how to set up custom fields

Closes #4281

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@abey
Improved beszel documentation
1a46c97 
- Fixed Beszel repo link
- Added information about where to find `systemId`
- Added information about how to set up custom fields
shamoon
shamoon requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but please remove the bit about fields at the bottom. That information is true for any widget and doesn’t specifically belong here.

@shamoon shamoon changed the title Improved Beszel widget documentation Documentation: corrections Beszel widget docs Nov 12, 2024
@shamoon shamoon enabled auto-merge (squash) November 12, 2024 14:18
@shamoon shamoon merged commit d87d347 into gethomepage:dev Nov 12, 2024
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey @shamoon