feat: rooms out of beta #118
Conversation
✅ Deploy Preview for hoppdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| type Room struct { | ||
| ID string `json:"id" gorm:"unique;not null"` // Standard field for the primary key | ||
| Name string `gorm:"not null" json:"name" validate:"required"` | ||
| UserID string `gorm:"not null" json:"user_id" validate:"required"` |
There was a problem hiding this comment.
It seems that we don't use this anywhere. We are only using the TeamID for creating/deleting/gettings/modifying.
There was a problem hiding this comment.
We do not use if for now, but actually save it in the DB. We will display this metadata in the future for reference of who created the room. Just did not have time to implement it now 🤷
| return c.NoContent(http.StatusNoContent) | ||
| } | ||
|
|
||
| func (h *AuthHandler) GetRoom(c echo.Context) error { |
There was a problem hiding this comment.
Nit: Should this be named EnterRoom?
There was a problem hiding this comment.
Name just resembled the method GET in this case. This reminds me that a renaming of all the handlers to conform with this approach should be done shortly
tauri/src/store/store.ts
Outdated
| reset: () => void; | ||
| setCalling: (calling: string | null) => void; | ||
| setCallTokens: (tokens: CallState | null) => void; | ||
| // setRoom: (room: components["schemas"]["Room"] | null) => void; |
There was a problem hiding this comment.
Nope, that was used in the initial implementation, state moved inside the CallState, removing
3 participants
Closes #21
Co-developed with @mumair5393