refact!: Models fields use models picker dialogs #7522
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
4 times, most recently
from
a4ed279 to
52a752a
Compare
2 tasks
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
from
52a752a to
ad089d8
Compare
distantnative
changed the base branch from
v6/develop
to
v6/refact/models-picker-dialogs-controllers-classes
Base automatically changed from
v6/refact/models-picker-dialogs-controllers-classes
to
v6/develop
August 13, 2025 10:55
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
2 times, most recently
from
1aa18cc to
dfc5fcc
Compare
distantnative
changed the base branch from
v6/develop
to
v6/refact/field-mixin-picker
distantnative
changed the title
distantnative
changed the title
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
9 times, most recently
from
40cd2bc to
e1d00b0
Compare
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
from
e1d00b0 to
fe7633f
Compare
3 tasks
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
from
fe7633f to
beb5075
Compare
distantnative
changed the base branch from
v6/develop
to
v6/refact/models-picker-dialog-vue
Base automatically changed from
v6/refact/models-picker-dialog-vue
to
v6/develop
August 22, 2025 17:53
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
from
beb5075 to
cbb78ce
Compare
distantnative
commented
Aug 22, 2025
| @@ -48,9 +49,6 @@ | |||
| 'parent' => function () { | |||
| return $this->parentModel->apiUrl(true); | |||
| }, | |||
| 'query' => function () { | |||
| return $this->query ?? $this->parentModel::CLASS_ALIAS . '.files'; | |||
| }, | |||
There was a problem hiding this comment.
Explanation: Query default is handled by new FIlePickerDialogController class.
| } | ||
| 'pattern' => 'items', | ||
| 'method' => 'GET', | ||
| 'action' => fn () => $this->field()->itemsFromRequest() |
There was a problem hiding this comment.
I didn't found a better way as api routes cannot be defined by a mixin as it seems.
| } | ||
| } | ||
|
|
||
| return $items; | ||
| return $ids; |
There was a problem hiding this comment.
Review: Does it make sense that we always use IDs here and not UUIDs? Since we use ->toModel()->{$store) in the save callback, it should work consistently to always just communicate with the IDs. But wondering if conceptually we should also use $uuid?? $id here.
distantnative
force-pushed
the
v6/refact/models-picker-dialogs-controllers
branch
from
cbb78ce to
225da0b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| false => $file->filename() | ||
| }; | ||
|
|
||
| return $file->id(); |
Check failure
Code scanning / Psalm
UnevaluatedCode Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge first:
::pickerData()for models #7510pickerfield mixin #7528Todo
Changelog
♻️ Refactored
☠️ Deprecated
k-models-dialog,k-pages-dialog,k-files-dialogandk-users-dialoghave been deprecated. Usek-models-picker-dialog,k-pages-picker-dialog,k-files-picker-dialog,k-users-picker-dialoginstead.Kirby\Cms\Picker,Kirby\Cms\PagePicker,Kirby\Cms\FilePickerandKirby\Cms\UserPickerhave been deprecated. UseKirby\Panel\Controller\Dialog\ModelsPickerDialogController,Kirby\Panel\Controller\Dialog\PagesPickerDialogController,Kirby\Panel\Controller\Dialog\FilesPickerDialogControllerandKirby\Panel\Controller\Dialog\UsersPickerDialogControllerinstead.🚨 Breaking changes
pagepicker,filepickeranduserpickerfield mixinsFor review team