Skip to content

fix: respect case preferences when grouping by callable #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop-patch
Choose a base branch
from
Open

fix: respect case preferences when grouping by callable #7563

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8f7e55
fix: respect case preferences when grouping by callable
dweidner Aug 20, 2025
9d0fe32
test: add test case for case sensitive grouping
dweidner Aug 26, 2025
47446cd
style: reverse changes in code formatting
dweidner Aug 26, 2025
6e0d484
style: fix code indentation
dweidner Aug 26, 2025
ff1acef
style: reverse changes in code formatting
dweidner Aug 26, 2025
07ab9e1
style: fix formatting of arrow functions
dweidner Aug 26, 2025
51a6778
test: add test assertions
dweidner Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Toolkit/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ public function group(
}
}

return new self($groups);
return new self($groups, !$caseInsensitive);
}

throw new Exception(
Expand Down
30 changes: 30 additions & 0 deletions tests/Toolkit/CollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,36 @@ public function testGroupByWithInvalidKey(): void
$collection->group(1);
}

public function testGroupByCallableCaseSensitive(): void
{
$collection = new Collection();

$collection->taylor = [
'name' => 'Taylor',
'genre' => 'Pop',
];

$collection->justin = [
'name' => 'Justin',
'genre' => 'Pop',
];

$collection->aubrey = [
'name' => 'Aubrey',
'genre' => 'Hip-Hop',
];

$groupsCaseInsensitive = $collection->group(fn (array $item) => $item['genre'], true);

$this->assertTrue($groupsCaseInsensitive->has('pop'));
$this->assertTrue($groupsCaseInsensitive->has('hip-hop'));

$groupsCaseSensitive = $collection->group(fn (array $item) => $item['genre'], false);

$this->assertTrue($groupsCaseSensitive->has('Pop'));
$this->assertTrue($groupsCaseSensitive->has('Hip-Hop'));
}

public function testIndexOf(): void
{
$this->assertSame(1, $this->collection->indexOf('My second element'));
Expand Down