Repository navigation
feat: add coverage-aware audit reports - #345
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit's existing output does not provide a versioned inventory/completeness contract, so automation cannot reliably distinguish an empty mcpm store from an incomplete assessment. Add the explicit CLI-only
mcpm audit --report-jsonopt-in while preserving legacy JSON (including empty-inventory text and fix wrappers), SARIF, served MCP audit results, scoring and safety gates.The version-1 report identifies its mcpm-store/latest-metadata scope, selected checks and exclusions; retains valid siblings beside inventory or registry failures; and separates empty inventory, findings, no findings and incomplete assessment. Reuse the bounded strict reader, with fixed diagnostics and reduced findings that omit raw values. Report mode rejects mutation/other-output flags. Configured external scanners retain their existing explicit execution behavior; this is not installed-code, whole-host or native safety evidence.
This is a bounded first slice of project backlog IDs #131/#149, which remain open for broader client-read coverage. Update the report/CLI/agent contracts, public usage skill 1.3.2, relevant backlog/maintainer docs and Obsidian. Homepage, remaining-docs cleanup and #331 remain separate.
Sol implemented; Astra independently reviewed and guided fixes for strict bounded input, scope/privacy and registry response identity. Original feature head:
90b05e7572fca9272d80206d5a8280b6fd920a9c. Integrated current main atca5d499898f2fbeb8ecb5718e9acca38b395ff95; Astra independently verified identical runtime/package/lock/skill bytes and preservation of unrelated main files. Fresh exact-head CI is required before merge.Validation:
1907f66for legacy empty/valid JSON, text, SARIF and fix-JSON. New cases cover partial/failed evidence, scanner output, malformed/future/duplicate stores, special files, privacy and invalid flags; report fixtures remain unchanged and no configured synthetic server launches.Limits: fixed mcpm-store inventory and latest publication metadata only; no installed-byte, client discovery, health, native/provider/model proof or release authentication. No Obsidian visual rendering or exhaustive external-link check. No merge or release included.