Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: MyPy U #6265

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Techdebt: MyPy U #6265

merged 1 commit into from
Apr 29, 2023

Conversation

bblommers
Copy link
Collaborator

MyPy currently does not support our usecase for the paginate-decorator, which means that we have to add type: ignore everywhere.

In the future, it should be typed using ParamSpec
https://stackoverflow.com/a/70591060/13245310

I believe this will work after python/mypy#14903 is accepted

@bblommers bblommers added this to the 4.1.9 milestone Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Merging #6265 (e86d2c8) into master (2cd773f) will decrease coverage by 0.01%.
The diff coverage is 93.51%.

@@            Coverage Diff             @@
##           master    #6265      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         787      787              
  Lines       76655    76656       +1     
==========================================
- Hits        73837    73836       -1     
- Misses       2818     2820       +2     
Flag Coverage Δ
servertests 36.97% <90.74%> (-0.01%) ⬇️
unittests 96.26% <93.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/utilities/distutils_version.py 61.40% <75.00%> (ø)
moto/utilities/docker_utilities.py 97.72% <83.33%> (-2.28%) ⬇️
moto/utilities/aws_headers.py 91.93% <84.61%> (-2.71%) ⬇️
moto/cognitoidp/models.py 95.64% <100.00%> (ø)
moto/databrew/models.py 96.80% <100.00%> (ø)
moto/dax/models.py 99.20% <100.00%> (ø)
moto/ds/models.py 96.29% <100.00%> (ø)
moto/events/models.py 95.02% <100.00%> (ø)
moto/glue/models.py 97.20% <100.00%> (ø)
moto/iot/models.py 93.34% <100.00%> (ø)
... and 11 more

@bblommers bblommers merged commit e2d3582 into getmoto:master Apr 29, 2023
@github-actions
Copy link
Contributor

This is now part of moto >= 4.1.9.dev16

@bblommers bblommers deleted the techdebt/mypy-u branch April 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant