Improve non-root site handling of nikola auto. Fix 3715. #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknrdureegaesr
force-pushed
the
devserver_nonbase
branch
from
f2f3f9b
to
898ff63
Compare
Kwpolska
approved these changes
Jan 4, 2024
Comment on lines
+160
to
+161
| # For this case, the auto module has special code | ||
| # (at module load time! 😟) which we reluctantly reproduce here: |
There was a problem hiding this comment.
This was required to work around a bug in asyncio, IIRC it prevented shutting down the server with ^C. You may move it to some later point than loading the module.
| ("https://lorem.ipsum/dolet/", "/dolet"), | ||
| ("http://example.org:124/blog", "/blog"), | ||
| ("http://example.org:124/Deep/Rab_bit/hol.e/", "/Deep/Rab_bit/hol.e"), | ||
| # Would anybody in a sane mind actually do this? |
There was a problem hiding this comment.
No, I doubt it would work in any reasonable way.
Co-authored-by: Chris Warrick <[email protected]>
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
If
conf["SITE_URL"]points to some non-root path, thennikola auto --browsernow