Skip to content

Tweak vertical alignment of tab badges#1016

Closed
matthew-white wants to merge 1 commit intomasterfrom
align-tab-badge
Closed

Tweak vertical alignment of tab badges#1016
matthew-white wants to merge 1 commit intomasterfrom
align-tab-badge

Conversation

@matthew-white
Copy link
Copy Markdown
Member

This PR makes small adjustments to the vertical alignment of tab badges. It attempts to address getodk/central#671 (comment).

What has been done to verify that this works as intended?

Trying it out locally.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from ktuite July 26, 2024 21:56
@lognaturel
Copy link
Copy Markdown
Member

@matthew-white will put this on the QA server so Szymon can verify it because he's the only one who can reproduce currently.

@matthew-white
Copy link
Copy Markdown
Member Author

In the time since I created this PR, I've seen other cases where vertical alignment is correct on my machine, but not correct for Szymon. This PR just makes changes to tab badges, but I'm thinking that the issue is probably more systemic. I've filed getodk/central#963 about this issue. I'll go ahead close this PR.

@matthew-white matthew-white deleted the align-tab-badge branch April 16, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants