Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move file for DatasetPropertyNew component #1082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

Move file for DatasetPropertyNew component #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/dataset/overview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ except according to the terms contained in the LICENSE file.
import PageSection from '../page/section.vue';
import ConnectionToForms from './overview/connection-to-forms.vue';
import LinkedForms from './overview/linked-forms.vue';
import DatasetPropertyNew from './overview/new-property.vue';
import DatasetPropertyNew from './property/new.vue';
import DatasetProperties from './overview/dataset-properties.vue';

import { modalData } from '../../util/reactivity';
Expand Down
1 change: 1 addition & 0 deletions ...ponents/dataset/overview/new-property.vue → src/components/dataset/property/new.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ const submit = () => {

<i18n lang="json5">
{
// @transifexKey component.DatasetOverviewNewProperty
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly filenames don't really matter, but the one place where they do have an effect is in Transifex. For Transifex, the string key is based on the filename, under the assumption that the filename will match the component name. (I couldn't think of a better way for our Transifex scripts to figure out the component name.) We don't want these messages to be retranslated, which is why I'm specifying @transifexKey here.

"en": {
// This is the title at the top of a pop-up.
"title": "Add Entity Property",
Expand Down
2 changes: 1 addition & 1 deletion ...nts/dataset/overview/property-new.spec.js → test/components/dataset/property/new.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import DatasetPropertyNew from '../../../../src/components/dataset/overview/new-property.vue';
import DatasetPropertyNew from '../../../../src/components/dataset/property/new.vue';
import DatasetProperties from '../../../../src/components/dataset/overview/dataset-properties.vue';
import ConnectionToForm from '../../../../src/components/dataset/overview/connection-to-forms.vue';

Expand Down