Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of DlData #1083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests of DlData #1083

wants to merge 1 commit into from

Conversation

matthew-white
Copy link
Member

This PR adds tests of the new DlData component. That component was added in #1074, but tests weren't updated as part of that PR. DlData is tested indirectly through the tests of EntityData. However, I think it'd be better to add tests of DlData specifically, then just test that EntityData passes the correct props to DlData. The entity hover card will use DlData, and I'll want to test it in a similar way, testing that it passes the correct props.

The existing tests of EntityData were already pretty comprehensive, so I'm basically just moving them and reworking them to mount DlData instead of EntityData.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from ktuite December 7, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants