Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests of the new
DlData
component. That component was added in #1074, but tests weren't updated as part of that PR.DlData
is tested indirectly through the tests ofEntityData
. However, I think it'd be better to add tests ofDlData
specifically, then just test thatEntityData
passes the correct props toDlData
. The entity hover card will useDlData
, and I'll want to test it in a similar way, testing that it passes the correct props.The existing tests of
EntityData
were already pretty comprehensive, so I'm basically just moving them and reworking them to mountDlData
instead ofEntityData
.Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes