Add devTools flag to config and use it to gate EntityBranchData #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
Dec 13, 2024
| @@ -154,7 +155,8 @@ const requestDelete = () => { | |||
| .catch(noop); | |||
| }; | |||
|
|
|||
| const branchData = modalData(); | |||
| const EntityBranchData = defineAsyncComponent(loadAsync('EntityBranchData')); | |||
There was a problem hiding this comment.
The component will only be loaded if it's rendered (if the v-if is true). So it won't ever have to be loaded for users.
sadiqkhoja
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment on the release criteria for v2024.2 asks whether we should prevent showing
EntityBranchDataunless a Frontend config is set. I think that's a good idea. It's not impossible that a user would randomly click "Offline update", and it'd be confusing if they did.What has been done to verify that this works as intended?
I tried it out locally. If the config is set to
true, I can see the modal, and if it's set tofalse, I can't. Since this modal is only for development/testing, I don't think we need to write automated tests about it.Why is this the best possible solution? Were any other approaches considered?
I named the config something generic:
devTools. In the future, I think there will probably be other examples of things like this modal.Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes