Add Swahili #544
Merged
Add Swahili #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
Feb 19, 2022
| @@ -87,7 +87,7 @@ class PluralForms { | |||
| // Transifex uses ICU plurals. | |||
| static fromTransifex(string, locale) { | |||
| const forms = []; | |||
| const icuMatch = string.match(/^({count, plural,).+}$/); | |||
| const icuMatch = string.match(/^({count, plural,).+}$/s); | |||
There was a problem hiding this comment.
Comment on lines
-83
to
-86
| // If this.$i18n.locale changes, this.config will change, but flatpickr | ||
| // itself won't change: | ||
| // https://github.com/flatpickr/flatpickr/issues/1882 | ||
| // https://github.com/flatpickr/flatpickr/issues/2019 |
There was a problem hiding this comment.
This seems to be working now! Because of that, I removed these comments.
Comment on lines
285
to
296
| it('specifies a flatpickr locale if the i18n locale is es', () => | ||
| loadLocale('es') | ||
| .then(() => { | ||
| const { locale } = mountComponent().vm.config; | ||
| locale.weekdays.longhand[0].should.equal('Domingo'); | ||
| }) | ||
| .finally(() => loadLocale('en'))); | ||
| it('renders correctly for es', async () => { | ||
| await loadLocale('es'); | ||
| const component = mountComponent({ attachTo: document.body }); | ||
| await component.get('input').trigger('click'); | ||
| const text = document.querySelector('.flatpickr-weekday').textContent.trim(); | ||
| text.should.equal('Lun'); | ||
| }); |
There was a problem hiding this comment.
Instead of inspecting the config computed property, we actually cause the flatpickr element to be rendered, then inspect the element. That feels like a surer test that things are working and actually wasn't that much more complicated to write.
matthew-white
force-pushed
the
add-sw
branch
from
77c943f to
7b79423
Compare
|
The Swahili translations have been reviewed, and I've updated the last commit. Swahili should be ready to go out with v1.4! |
ktuite
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Swahili to Frontend. This required a couple of changes in addition to the usual tasks.
First, there was an error parsing the Transifex JSON, because the translator used a
\n. That shouldn't have been a problem, because we convert\nin Transifex strings to space. Actually, the Transifex JSON for Japanese also seems to contain strings with\nwithout issue. However, the presence of\nspecifically within a pluralized string resulted in an error here. Luckily, a small change to a regular expression was all that was needed.Second, Swahili is the first locale for us for which there isn't a flatpickr localization. I think we should consider submitting a PR to flatpickr for that, since I think it'd be pretty easy. However, for now, I modified
DateRangePickerso that it works even if there isn't a flatpickr localization (it falls back to English). I didn't want to add more flatpickr-related logic tosrc/util/i18n.jsas part of that and instead decided to move the existing flatpickr logic in that file intoDateRangePicker. The result is more consistent with how we approach internationalization in other components. I had also already made that change as part of moving to Vue 3 (in #526). That PR makes a few changes tosrc/util/i18n.js, in large part because the i18n object will no longer be a global object. More about flatpickr localization: https://flatpickr.js.org/localization/I may update the last commit as translations are updated, but I don't plan to make changes to the other commits. Because of that, I think we can go ahead and review this PR. An interactive review would probably be easiest, but I think async would also work. Because this PR touches the same file as the Vue 3 PR, it'd be good to merge it soon. (Swahili will hopefully be ready by the time we want to release, but even if we decide to release it in a patch, we'd be able to temporarily hide these translations.)