Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable liveReload for development #876

Closed
wants to merge 1 commit into from

Conversation

sadiqkhoja
Copy link
Contributor

@sadiqkhoja sadiqkhoja commented Oct 19, 2023

Accept this only if it works for everyone and their workflows

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white
Copy link
Member

What do you think about including this as an additional command rather than replacing the current behavior? I'm thinking that npm run dev could continue to build and watch like it does today, then something like npm run dev:live could run a dev server and use live reload. Just for myself, my personal preference isn't to use live reload. One thing that I like to do sometimes during local development is to compare two versions side-by-side, to check for differences in styles or behavior. I don't think that'd be possible with live reload. That said, I can also see what's nice about live reload, and I wouldn't want to block others from using it.

One thing that I'm unsure about is how we would make this an option from the nginx side. Is it possible to add some sort of switch in the nginx config? Otherwise, could we use something like envsubst to pass in either root ./dist; or proxy_pass to the config?

I'm making progress on moving Frontend from Vue CLI to Vite (#671). I think things in this area will work a little differently under Vite, so this PR will need to change. I'm thinking that we should close this PR, then open a new one once I'm done with Vite. What do you think?

@sadiqkhoja
Copy link
Contributor Author

Agree, we can take this up again once Vue CLI is replaced with vite.

@sadiqkhoja sadiqkhoja closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants