Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geopoint column width in submission #975

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Apr 22, 2024

Closes getodk/central#635

Makes sure geopoint column has room to grow to show entire value. The value is often very close to 250px but this ensures that it can use a bit more if it needs to.

Screenshot 2024-04-22 at 5 07 37 PM

The problem before was a max-width: 500px CSS rule that wasn't getting applied because of change in a different file (submissions/table.vue) that was canceling out the CSS. Using the extra class selector (.table-freeze-scrolling) from the other file worked to have this greater max width go into effect again, and provide a clue to CSS effects from this other file.

This PR mentions

We don't add tooltips for field types whose text shouldn't be truncated: int, decimal, date, time, dateTime, and geopoint. (geopoint columns are styled to be up to twice as wide as others.)

What has been done to verify that this works as intended?

Tried it!

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from matthew-white April 22, 2024 22:25
@ktuite ktuite force-pushed the ktuite/geopoint_tooltip branch from 8807d13 to d664e8e Compare April 23, 2024 00:07
@ktuite ktuite changed the title Remove special treatment of geopoint in submission for tooltips Fix geopoint column width in submission Apr 23, 2024
@ktuite ktuite merged commit f3c108c into master Apr 23, 2024
1 check passed
@ktuite ktuite deleted the ktuite/geopoint_tooltip branch April 23, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tooltip in submissions table in geopoints
2 participants