Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show warning if CSV delimiter is not a comma #978

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

matthew-white
Copy link
Member

@matthew-white matthew-white commented Apr 24, 2024

This PR changes what happens if something other than a comma is used as the CSV delimiter. A non-comma delimiter will continue to be shown in EntityHeaderErrors if the header row is invalid. However, it will not be returned in the warnings from parseCSV() or shown in EntityUploadWarnings.

What has been done to verify that this works as intended?

I updated tests to match the new behavior.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removals look good. Is there still a test that verifies the message is shown in the expected case? I'm not quickly finding it. Maybe it's not that important?

@matthew-white
Copy link
Member Author

Ah yes, that's a test that was missing. There are still a number of those, and I've filed the issue #979 about that. But this is probably as good a time as any to add that missing test. I've just pushed a commit that tests that the EntityUploadHeaderErrors component use the delimiter from the CSV file.

@matthew-white matthew-white merged commit f0c272e into upload-warnings Apr 25, 2024
1 check passed
@matthew-white matthew-white deleted the delimiter-warning branch April 25, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants