Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make small changes to ESLint config #993

Merged
merged 1 commit into from
May 10, 2024
Merged

Make small changes to ESLint config #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
module.exports = {
root: true,
parserOptions: {
ecmaVersion: 2020
ecmaVersion: 'latest'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We target the latest two browser versions, so I think latest makes sense. We certainly aren't targeting 2020.

},
extends: [
'plugin:vue/vue3-recommended',
'@vue/airbnb'
],
env: {
node: true
},
Comment on lines -10 to -12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env tells ESLint which variables are global variables so it doesn't flag them. However, Frontend isn't a Node project, so specifying node here doesn't make sense. The actual global variables that we use are listed below under globals.

globals: {
$: 'readonly',
alert: 'readonly',
Expand Down