Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See update conflicts in Entity table #504

Closed
matthew-white opened this issue Sep 26, 2023 · 5 comments
Closed

See update conflicts in Entity table #504

matthew-white opened this issue Sep 26, 2023 · 5 comments
Assignees
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@matthew-white matthew-white added enhancement New feature or behavior backend Requires a change to the API server frontend Requires a change to the UI needs testing Needs manual testing needs design review Needs verification from designer entities Multiple Encounter workflows labels Sep 26, 2023
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Sep 26, 2023
@sadiqkhoja sadiqkhoja self-assigned this Oct 17, 2023
@sadiqkhoja sadiqkhoja moved this from 🕒 backlog to ✏️ in progress in ODK Central Oct 17, 2023
@sadiqkhoja sadiqkhoja moved this from ✏️ in progress to ✅ done in ODK Central Oct 31, 2023
@matthew-white
Copy link
Member Author

I'm going to move this back to "in progress", since I still need to add the conflict summary table to the modal (#529). I'll assign myself to the issue. Once the table is done, I think this story will be ready for QA and design review.

@matthew-white matthew-white moved this from ✅ done to ✏️ in progress in ODK Central Nov 1, 2023
@matthew-white matthew-white self-assigned this Nov 1, 2023
@sadiqkhoja sadiqkhoja removed their assignment Nov 2, 2023
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Nov 23, 2023
@issa-tseng
Copy link
Member

there's awkwardly much distance between the alert icon and the >
if i take 8px out of the distance it looks nicer but it seems like it should be aligned or floated right instead of the width being changed as i did it

as i think sadiq expressed, the alert icon is pretty big. if i take the icon font size down to 12px, the circle to 22px, and realign the icon it looks nicer

as szymon notes, titlebar is still magenta. i can live with it

at least in safari i see the first header column is collapsed, that column we should see at least the full static contents.
Image

have not personally tested project viewer but looks good otherwise

@srujner
Copy link

srujner commented Dec 5, 2023

Tested with Success!

@dbemke
Copy link

dbemke commented Dec 5, 2023

Tested with Success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Dec 5, 2023
@matthew-white
Copy link
Member Author

there's awkwardly much distance between the alert icon and the > if i take 8px out of the distance it looks nicer but it seems like it should be aligned or floated right instead of the width being changed as i did it

as i think sadiq expressed, the alert icon is pretty big. if i take the icon font size down to 12px, the circle to 22px, and realign the icon it looks nicer

I've made these changes as part of getodk/central-frontend#903. I similarly adjusted the alert icon in the table of entity lists.

at least in safari i see the first header column is collapsed, that column we should see at least the full static contents.

I left a related comment about these column widths in the release criteria.

have not personally tested project viewer but looks good otherwise

I don't think this was in place when you took a look, but it should be now that #538 is closed.

@matthew-white matthew-white removed the needs design review Needs verification from designer label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

No branches or pull requests

5 participants