Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity conflict summary table #529

Closed
matthew-white opened this issue Oct 27, 2023 · 2 comments · Fixed by getodk/central-frontend#894
Closed

Add entity conflict summary table #529

matthew-white opened this issue Oct 27, 2023 · 2 comments · Fixed by getodk/central-frontend#894
Assignees
Labels
entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

For two stories in v2023.5 (#504 and #505), we need a table to summarize unresolved entity conflicts. This issue is to create a component for that table that can be used on either the entities data page or the entity detail page.

@matthew-white
Copy link
Member Author

Most of the work for this was done in getodk/central-frontend#894. However, I need to write tests, including for the following cases:

  • Test that the status icon is correct for a historical version that was a conflict and is now resolved.
  • Test the return from the update modal:
    • If there was an update, then the table should be refreshed.
    • If there wasn't an update, then there should be no request. However, the table should still be visible.

@matthew-white
Copy link
Member Author

I didn't finish writing these tests before the release of v2023.5, so I've filed a new issue to do so: getodk/central-frontend#923. Even though the conflict summary table passed QA, I think it's important that we have tests of this functionality.

@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

1 participant