Skip to content

Commit

Permalink
fix(credentials): return nil instead of empty error group
Browse files Browse the repository at this point in the history
- Update ResolveAll to return ErrorOrNil() instead of raw error group
- Ensures consistent error handling when no errors occurred during resolution

Signed-off-by: Kim Christensen <[email protected]>
  • Loading branch information
kichristensen committed Jan 2, 2025
1 parent b61631f commit d791029
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/storage/credential_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (s CredentialStore) ResolveAll(ctx context.Context, creds CredentialSet, ke
resolvedCreds[cred.Name] = value
}

return resolvedCreds, resolveErrors
return resolvedCreds, resolveErrors.ErrorOrNil()
}

func (s CredentialStore) Validate(ctx context.Context, creds CredentialSet) error {
Expand Down

0 comments on commit d791029

Please sign in to comment.