Skip to content

Handle download in pdf preview #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
+16 −2
Merged

Handle download in pdf preview #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/console/src/components/documents/PDFPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ export function PDFPreview({ src, name }: { src: string; name?: string }) {
}
};

const handleDownload = () => {
const link = document.createElement("a");
link.href = src;
link.download = name || "document.pdf";
link.click();
Copy link

@cubic-dev-ai cubic-dev-ai bot Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Programmatic download fails in browsers like Firefox because the anchor is never added to the DOM before click(). Attach it to document.body before triggering the click and remove it afterward.

Prompt for AI agents 
Address the following comment on apps/console/src/components/documents/PDFPreview.tsx at line 78:

<comment>Programmatic download fails in browsers like Firefox because the anchor is never added to the DOM before click(). Attach it to document.body before triggering the click and remove it afterward.</comment>

<file context>
@@ -71,6 +71,13 @@ export function PDFPreview({ src, name }: { src: string; name?: string }) {
+    const link = document.createElement(&quot;a&quot;);
+    link.href = src;
+    link.download = name || &quot;document.pdf&quot;;
+    link.click();
+  };
+
</file context>
Fix with Cubic

Copy link
Contributor Author

@SachaProbo SachaProbo Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine in firefox

};

return (
<div className="grid grid-rows-[max-content_1fr] h-full bg-subtle">
{/* Custom Zoom Controls */}
Expand All @@ -97,7 +104,7 @@ export function PDFPreview({ src, name }: { src: string; name?: string }) {
<button onClick={zoomFactor(1.2)} className={btnClass}>
<IconPlusLarge size={16} />
</button>
<button onClick={zoomFactor(1.2)} className={btnClass}>
<button onClick={handleDownload} className={btnClass}>
<IconArrowInbox size={16} />
</button>
</nav>
Expand Down
9 changes: 8 additions & 1 deletion apps/trust/src/components/PDFPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ export function PDFPreview({ src, name }: { src: string; name?: string }) {
}
};

const handleDownload = () => {
const link = document.createElement("a");
link.href = src;
link.download = name || "document.pdf";
link.click();
};

return (
<div className="grid grid-rows-[max-content_1fr] h-full bg-subtle">
{/* Custom Zoom Controls */}
Expand All @@ -97,7 +104,7 @@ export function PDFPreview({ src, name }: { src: string; name?: string }) {
<button onClick={zoomFactor(1.2)} className={btnClass}>
<IconPlusLarge size={16} />
</button>
<button onClick={zoomFactor(1.2)} className={btnClass}>
<button onClick={handleDownload} className={btnClass}>
<IconArrowInbox size={16} />
</button>
</nav>
Expand Down