Skip to content

fix(down): Enable bringing down starting services#211

Merged
IanWoodard merged 1 commit intomainfrom
iw/starting-state
Jan 15, 2025
Merged

fix(down): Enable bringing down starting services#211
IanWoodard merged 1 commit intomainfrom
iw/starting-state

Conversation

@IanWoodard
Copy link
Copy Markdown
Contributor

Currently, you can only bring down services that have been completely brought up. This is not ideal as it makes it difficult to bring down services that are partially up, forcing users to use the purge command. This change improves down so that you can bring down services once they start being brought up even if they are not fully up.
https://getsentry.atlassian.net/browse/DEVINFRA-455

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (34f05b2) to head (e2c9987).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   92.74%   92.78%   +0.04%     
==========================================
  Files          22       22              
  Lines        1557     1567      +10     
==========================================
+ Hits         1444     1454      +10     
  Misses        113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit fc673cd into main Jan 15, 2025
@IanWoodard IanWoodard deleted the iw/starting-state branch January 15, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants