Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dependencies): Improving error handling for dependency logic #215

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

IanWoodard
Copy link
Member

@IanWoodard IanWoodard commented Jan 16, 2025

https://getsentry.atlassian.net/browse/DEVINFRA-598. Adding additional error handling to the core dependency logic. Fixed the _run_command function to now properly propagate the stderr which it did not do previously which should now give us more information into the failures we see. For now I opted not to add retries to anything besides fetch since fetch is by far the most likely to face transient errors, and retrying certain other commands can put us in a potentially problematic state.
More improvements to the core dependency logic, specifically around the git config are coming in another PR.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (df61e38) to head (a2387bb).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   92.58%   92.67%   +0.08%     
==========================================
  Files          22       22              
  Lines        1578     1597      +19     
==========================================
+ Hits         1461     1480      +19     
  Misses        117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanWoodard IanWoodard merged commit 16c17a4 into main Jan 17, 2025
14 checks passed
@IanWoodard IanWoodard deleted the iw/dependency-error-handling branch January 17, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants