ref(dependencies): Improving error handling for dependency logic #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getsentry.atlassian.net/browse/DEVINFRA-598. Adding additional error handling to the core dependency logic. Fixed the
_run_command
function to now properly propagate the stderr which it did not do previously which should now give us more information into the failures we see. For now I opted not to add retries to anything besides fetch since fetch is by far the most likely to face transient errors, and retrying certain other commands can put us in a potentially problematic state.More improvements to the core dependency logic, specifically around the git config are coming in another PR.