Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Replace release bot with GH app #742

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

@Jeffreyhung Jeffreyhung merged commit 7a6348a into master Dec 4, 2024
16 checks passed
@Jeffreyhung Jeffreyhung deleted the Replace-release-bot-with-GH-app branch December 4, 2024 19:33
@beliaev-maksim
Copy link
Collaborator

@Jeffreyhung that is not very convenient when notes for open source project are published in internal source. That lowers the visibility on decisions

@Jeffreyhung
Copy link
Member Author

@beliaev-maksim appreciate the feedback, we are making this change across 70+ repos and I didn't find a suitable place in our GitHub to put it, so I put it in Notion to save some duplicate contents across the 70+ repos.

But for more context, the getsentry-release is a GitHub bot account that is used in various automation, and the ${{ secrets.GH_RELEASE_PAT }} is a personal access token from that bot account. We are using a regular GitHub account as a bot while it should be a non-human account since there are no humans behind it. Hence, we are replacing it with a GitHub App. Functionality wise, there will be no difference.

@beliaev-maksim
Copy link
Collaborator

That makes sense, thanks for the context!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants