-
-
Notifications
You must be signed in to change notification settings - Fork 372
feat(metrics): Add integration with installation by SDK #6956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: philprime/metrics
Are you sure you want to change the base?
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## philprime/metrics #6956 +/- ##
=====================================================
Coverage ? 84.685%
=====================================================
Files ? 453
Lines ? 27483
Branches ? 12022
=====================================================
Hits ? 23274
Misses ? 4165
Partials ? 44
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
a5056fb to
1210307
Compare
|
|
||
| - Add attributes data to `SentryScope` (#6830) | ||
| - Add `SentryScope` attributes into log messages (#6834) | ||
| - Add integration to collect Metrics, can be enabled by setting `options.enableMetrics = true` (#6956) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 The changelog entry seems to be part of an already released section
## 9.1.0.
Consider moving the entry to the## Unreleasedsection, please.
📜 Description
This pull request introduces a new metrics integration to the Sentry SDK for Swift, allowing users to enable metrics collection and reporting via the SDK. The changes include the addition of the
enableMetricsoption, implementation of the metrics integration, updates to the SDK configuration, and new tests to verify the integration. The project structure is also updated to include the new integration and its tests.Metrics Integration Feature:
enableMetricsoption toSentryOptions, allowing users to enable or disable metrics collection. [1] [2]MetricsIntegration, which is installed whenenableMetricsis set totrue. [1] [2]enableMetricsoption. [1] [2]💡 Motivation and Context
Closes #6954
💚 How did you test it?
enableLogs📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.