-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Use at least xcode 16 for all jobs #7012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7012 +/- ##
=============================================
- Coverage 85.070% 84.986% -0.085%
=============================================
Files 454 454
Lines 27737 27548 -189
Branches 12157 12126 -31
=============================================
- Hits 23596 23412 -184
- Misses 4096 4097 +1
+ Partials 45 39 -6 see 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3b189e1 | 1231.11 ms | 1266.47 ms | 35.36 ms |
| 762a701 | 1219.96 ms | 1249.92 ms | 29.96 ms |
| a4bd249 | 1221.73 ms | 1251.09 ms | 29.35 ms |
| 7f2f69c | 1237.61 ms | 1266.96 ms | 29.35 ms |
| e3ca5b3 | 1229.26 ms | 1266.79 ms | 37.53 ms |
| 6b01cf3 | 1197.98 ms | 1219.88 ms | 21.90 ms |
| 331dad6 | 1210.40 ms | 1242.06 ms | 31.67 ms |
| 5bc23b4 | 1233.09 ms | 1270.47 ms | 37.38 ms |
| b7b4358 | 1224.05 ms | 1253.69 ms | 29.64 ms |
| 7148f97 | 1235.09 ms | 1258.07 ms | 22.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3b189e1 | 24.14 KiB | 1.02 MiB | 1019.58 KiB |
| 762a701 | 23.75 KiB | 1022.66 KiB | 998.91 KiB |
| a4bd249 | 24.14 KiB | 1.01 MiB | 1015.25 KiB |
| 7f2f69c | 23.75 KiB | 913.38 KiB | 889.63 KiB |
| e3ca5b3 | 24.14 KiB | 1.02 MiB | 1017.42 KiB |
| 6b01cf3 | 23.75 KiB | 1.00 MiB | 1005.08 KiB |
| 331dad6 | 23.75 KiB | 928.12 KiB | 904.37 KiB |
| 5bc23b4 | 24.14 KiB | 1.01 MiB | 1012.90 KiB |
| b7b4358 | 23.75 KiB | 1.00 MiB | 1005.08 KiB |
| 7148f97 | 23.75 KiB | 854.78 KiB | 831.03 KiB |
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bumps the version of Xcode used to at least 16 (16.2 on macOS 14) so we can use newer Xcode 16's features.
Also cleanups some steps and parameters that aren't neeed anymore.
Closes #7033