Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Dec 8, 2025

Bumps the version of Xcode used to at least 16 (16.2 on macOS 14) so we can use newer Xcode 16's features.

Also cleanups some steps and parameters that aren't neeed anymore.

Closes #7033

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.986%. Comparing base (83cd14a) to head (fc8c931).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7012       +/-   ##
=============================================
- Coverage   85.070%   84.986%   -0.085%     
=============================================
  Files          454       454               
  Lines        27737     27548      -189     
  Branches     12157     12126       -31     
=============================================
- Hits         23596     23412      -184     
- Misses        4096      4097        +1     
+ Partials        45        39        -6     

see 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83cd14a...fc8c931. Read the comment docs.

@itaybre itaybre changed the title chore: Use latest xcode for all UI tests chore: Use latest xcode for all jobs Dec 11, 2025
@itaybre itaybre changed the title chore: Use latest xcode for all jobs chore: Use at least xcode 16 for all jobs Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.31 ms 1252.51 ms 32.20 ms
Size 24.14 KiB 1.02 MiB 1022.54 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3b189e1 1231.11 ms 1266.47 ms 35.36 ms
762a701 1219.96 ms 1249.92 ms 29.96 ms
a4bd249 1221.73 ms 1251.09 ms 29.35 ms
7f2f69c 1237.61 ms 1266.96 ms 29.35 ms
e3ca5b3 1229.26 ms 1266.79 ms 37.53 ms
6b01cf3 1197.98 ms 1219.88 ms 21.90 ms
331dad6 1210.40 ms 1242.06 ms 31.67 ms
5bc23b4 1233.09 ms 1270.47 ms 37.38 ms
b7b4358 1224.05 ms 1253.69 ms 29.64 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms

App size

Revision Plain With Sentry Diff
3b189e1 24.14 KiB 1.02 MiB 1019.58 KiB
762a701 23.75 KiB 1022.66 KiB 998.91 KiB
a4bd249 24.14 KiB 1.01 MiB 1015.25 KiB
7f2f69c 23.75 KiB 913.38 KiB 889.63 KiB
e3ca5b3 24.14 KiB 1.02 MiB 1017.42 KiB
6b01cf3 23.75 KiB 1.00 MiB 1005.08 KiB
331dad6 23.75 KiB 928.12 KiB 904.37 KiB
5bc23b4 24.14 KiB 1.01 MiB 1012.90 KiB
b7b4358 23.75 KiB 1.00 MiB 1005.08 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB

Previous results on branch: itay/try_latest_xcode

Startup times

Revision Plain With Sentry Diff
fe6ecaa 1217.98 ms 1265.78 ms 47.80 ms

App size

Revision Plain With Sentry Diff
fe6ecaa 24.14 KiB 1.02 MiB 1022.54 KiB

@itaybre itaybre marked this pull request as ready for review December 11, 2025 22:04
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre itaybre merged commit fc43981 into main Dec 12, 2025
166 of 167 checks passed
@itaybre itaybre deleted the itay/try_latest_xcode branch December 12, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Use at least xcode 16 for all jobs

3 participants