Skip to content

Commit

Permalink
Enhance package validation + Remove Symbolic Links (#267)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucas-zimerman authored Apr 29, 2022
1 parent 70dccd1 commit 57786e7
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 2 deletions.
32 changes: 31 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ jobs:
GITHUB_ACCESS_TOKEN: ${{ secrets.GH_RELEASE_PAT }}
run: make build


job_artifacts:
name: Upload Artifacts
needs: [job_build, job_carthage_build]
Expand Down Expand Up @@ -160,3 +159,34 @@ jobs:
name: ${{ github.sha }}
path: |
${{ github.workspace }}/sentry-cordova-*
job_check_symlink:
name: Check for Symbolic Links
needs: [job_artifacts]
runs-on: macos-latest
defaults:
run:
shell: pwsh
steps:
- name: Checkout
uses: actions/[email protected]

- name: Download test app artifact
uses: actions/download-artifact@v2
with:
name: ${{ github.sha }}
path: |
${{ github.workspace }}/artifact
- name: Extract artifact
run: |
cd ${{ github.workspace }}/artifact
$bundleName = (Get-Item *.tgz).Name
tar -xvzf "$bundleName"
- name: Check if package contains any Symlink
run: |
$symLinks = (find "${{ github.workspace }}" -type l -ls)
if ($null -ne $symLinks) {
Write-Error "Atfifact contains illegal SymLinks`n$symLinks"
}
Write-Output "No Symbolic Links found, all good :)"
2 changes: 1 addition & 1 deletion .npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
*
!/dist/**/*
!/src/ios/Carthage/Build/Sentry.xcframework/**/*
!/src/ios/Carthage/Build/Sentry.xcframework/ios-*/**/*
!/src/ios/SentryCordova.*
!/src/android/**/*
!/scripts/**/*
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- Enhance package validation and Removed Symbolic Links ([#267](https://github.com/getsentry/sentry-cordova/pull/267))
- Sentry.xcframework being excluded by npm rule ([#266](https://github.com/getsentry/sentry-cordova/pull/266))

## 1.0.1
Expand Down

0 comments on commit 57786e7

Please sign in to comment.