Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): Fix jumpy search #12284

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 8, 2025

Fixes the laggy search bar in the changelog by not using query param state to feed into the search bar value and instead use plain old state. We manually keep the search bar in sync with the query params.

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:07pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 8:07pm
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 8:07pm

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, never noticed this before

@lforst lforst merged commit 3827711 into master Jan 9, 2025
12 checks passed
@lforst lforst deleted the lforst-fix-buggy-changelog-search branch January 9, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants