-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Kotlin): Merge Kotlin and Kotlin Multiplaform into one #12302
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.88kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! ig the only thing left is to improve the redirects as commented
@@ -908,6 +908,10 @@ const userDocsRedirects = [ | |||
source: '/platforms/javascript/guides/astro/manual-setup/', | |||
destination: '/platforms/javascript/guides/astro/', | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now using this instead of middleware.js
to also redirect all subpages
DESCRIBE YOUR PR
As discussed in #11848, we want to merge these to clean up the platforms landing page. KMP is now a (the only) sub-guide below Kotlin. The PR also adds a redirect for the KMP landing page.
fixes #11848
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES