fix(esbuild): Don't inject debug IDs into injected modules #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilty' into lforst-dont-inject-debug-ids-in-inject-files
lforst
changed the base branch from
lforst-add-integration-test-for-esbuild-inject-compatibilty
to
main
mydea
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413
When
injectfiles are defined in esbuild we will inject debug IDs into those files. This means we will have 2+ debug IDs in the output bundles which will potentially mess up our upload logic and debug ID association.With this PR we skip proxying injected modules therefore only injecting one debug ID per entrypoint (which is the desired outcome).