Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Write module injections to globalThis #636

Merged
merged 1 commit into from
Dec 5, 2024
Merged

feat(core): Write module injections to globalThis #636

merged 1 commit into from
Dec 5, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 5, 2024

Some runtimes like QuickJS only have globalThis.

@lforst lforst requested a review from Lms24 December 5, 2024 11:44
Lms24
Lms24 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me! Do we also need to adjust something in Sentry CLI?

@lforst
Copy link
Member Author

lforst commented Dec 5, 2024

Sounds reasonable to me! Do we also need to adjust something in Sentry CLI?

absolutely!

@lforst lforst merged commit 10e4689 into main Dec 5, 2024
18 checks passed
@lforst lforst deleted the lforst-globalthis branch December 5, 2024 11:55
@lforst lforst mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @Lms24