Skip to content

Commit

Permalink
feat(core)!: Remove deprecated Request type (#14858)
Browse files Browse the repository at this point in the history
This is named misleadingly, instead use `RequestEventData`.

Closes #14301
  • Loading branch information
mydea authored Dec 30, 2024
1 parent 888b05a commit 9030f37
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 24 deletions.
1 change: 1 addition & 0 deletions docs/migration/v8-to-v9.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ Sentry.init({
- The `flatten` export has been removed. There is no replacement.
- The `urlEncode` method has been removed. There is no replacement.
- The `getDomElement` method has been removed. There is no replacement.
- The `Request` type has been removed. Use `RequestEventData` type instead.

### `@sentry/browser`

Expand Down
2 changes: 0 additions & 2 deletions packages/browser/src/exports.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
export type {
Breadcrumb,
BreadcrumbHint,
// eslint-disable-next-line deprecation/deprecation
Request,
RequestEventData,
SdkInfo,
Event,
Expand Down
2 changes: 0 additions & 2 deletions packages/bun/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ export type {
Breadcrumb,
BreadcrumbHint,
PolymorphicRequest,
// eslint-disable-next-line deprecation/deprecation
Request,
RequestEventData,
SdkInfo,
Event,
Expand Down
2 changes: 0 additions & 2 deletions packages/cloudflare/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ export type {
Breadcrumb,
BreadcrumbHint,
PolymorphicRequest,
// eslint-disable-next-line deprecation/deprecation
Request,
RequestEventData,
SdkInfo,
Event,
Expand Down
2 changes: 0 additions & 2 deletions packages/core/src/types-hoist/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ export type {
export type {
QueryParams,
RequestEventData,
// eslint-disable-next-line deprecation/deprecation
Request,
SanitizedRequestData,
} from './request';
export type { Runtime } from './runtime';
Expand Down
6 changes: 0 additions & 6 deletions packages/core/src/types-hoist/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ export interface RequestEventData {
headers?: { [key: string]: string };
}

/**
* Request data included in an event as sent to Sentry.
* @deprecated: This type will be removed in v9. Use `RequestEventData` instead.
*/
export type Request = RequestEventData;

export type QueryParams = string | { [key: string]: string } | Array<[string, string]>;

/**
Expand Down
2 changes: 0 additions & 2 deletions packages/deno/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ export type {
Breadcrumb,
BreadcrumbHint,
PolymorphicRequest,
// eslint-disable-next-line deprecation/deprecation
Request,
RequestEventData,
SdkInfo,
Event,
Expand Down
2 changes: 0 additions & 2 deletions packages/node/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ export type {
Breadcrumb,
BreadcrumbHint,
PolymorphicRequest,
// eslint-disable-next-line deprecation/deprecation
Request,
RequestEventData,
SdkInfo,
Event,
Expand Down
4 changes: 0 additions & 4 deletions packages/types/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ import type {
ReplayEvent as ReplayEvent_imported,
ReplayRecordingData as ReplayRecordingData_imported,
ReplayRecordingMode as ReplayRecordingMode_imported,
Request as Request_imported,
RequestEventData as RequestEventData_imported,
Runtime as Runtime_imported,
SamplingContext as SamplingContext_imported,
Expand Down Expand Up @@ -379,9 +378,6 @@ export type QueryParams = QueryParams_imported;
/** @deprecated This type has been moved to `@sentry/core`. */
export type RequestEventData = RequestEventData_imported;
/** @deprecated This type has been moved to `@sentry/core`. */
// eslint-disable-next-line deprecation/deprecation
export type Request = Request_imported;
/** @deprecated This type has been moved to `@sentry/core`. */
export type SanitizedRequestData = SanitizedRequestData_imported;
/** @deprecated This type has been moved to `@sentry/core`. */
export type Runtime = Runtime_imported;
Expand Down
2 changes: 0 additions & 2 deletions packages/vercel-edge/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ export type {
Breadcrumb,
BreadcrumbHint,
PolymorphicRequest,
// eslint-disable-next-line deprecation/deprecation
Request,
RequestEventData,
SdkInfo,
Event,
Expand Down

0 comments on commit 9030f37

Please sign in to comment.