Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solidstart): Add autoInjectServerSentry: 'experimental_dynamic-import #14863

Draft
wants to merge 2 commits into
base: ab/solidstart-withsentry
Choose a base branch
from

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Dec 30, 2024

⚠️ THIS PR IS BASED ON #14862

Adds the option to dynamically import the server config file.

// app.config.ts
import { defineConfig } from '@solidjs/start/config';
import { sentrySolidStartVite, withSentry } from '@sentry/solidstart';

export default defineConfig(withSentry(
    { /* ... */ },
    { 
      autoInjectServerSentry: 'experimental_dynamic-import'
    })
 );

TODO: E2E test

@s1gr1d s1gr1d requested a review from andreiborza December 30, 2024 14:43
Copy link
Contributor

github-actions bot commented Dec 30, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23 KB added added
@sentry/browser - with treeshaking flags 21.72 KB added added
@sentry/browser (incl. Tracing) 35.54 KB added added
@sentry/browser (incl. Tracing, Replay) 72.8 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.23 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 77.21 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 89.6 KB added added
@sentry/browser (incl. Feedback) 39.77 KB added added
@sentry/browser (incl. sendFeedback) 27.62 KB added added
@sentry/browser (incl. FeedbackAsync) 32.38 KB added added
@sentry/react 25.74 KB added added
@sentry/react (incl. Tracing) 38.36 KB added added
@sentry/vue 27.25 KB added added
@sentry/vue (incl. Tracing) 37.41 KB added added
@sentry/svelte 23.17 KB added added
CDN Bundle 24.36 KB added added
CDN Bundle (incl. Tracing) 35.91 KB added added
CDN Bundle (incl. Tracing, Replay) 71 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.19 KB added added
CDN Bundle - uncompressed 71.41 KB added added
CDN Bundle (incl. Tracing) - uncompressed 106.88 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.95 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.82 KB added added
@sentry/nextjs (client) 38.66 KB added added
@sentry/sveltekit (client) 36.08 KB added added
@sentry/node 162.15 KB added added
@sentry/node - without tracing 98.89 KB added added
@sentry/aws-serverless 128.71 KB added added

Copy link

codecov bot commented Dec 30, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
12 3 9 0
View the top 3 failed tests by shortest run time
errors.server.test.ts server-side errorscaptures server action error
Stack Traces | 30s run time
errors.server.test.ts:5:3 captures server action error
performance.server.test.ts sends a server action transaction on pageload
Stack Traces | 30s run time
performance.server.test.ts:9:1 sends a server action transaction on pageload
performance.server.test.ts sends a server action transaction on client navigation
Stack Traces | 30s run time
performance.server.test.ts:32:1 sends a server action transaction on client navigation

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@s1gr1d s1gr1d force-pushed the sig/solidstart-dynamic-import branch from 6616ad1 to a13d2b6 Compare January 2, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant