Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add golangi-lint configuration #77

Merged
merged 8 commits into from
Dec 21, 2023
Merged

ci: Add golangi-lint configuration #77

merged 8 commits into from
Dec 21, 2023

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Dec 20, 2023

Let's lint more!

About golangci-lint: https://golangci-lint.run/

Linter can be triggered locally via running make lint.
More linters can be eventually enabled in .golangi.yml (the current config was mostly copied from https://github.com/getsentry/sentry-go/)

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b58f2c) 29.61% compared to head (e1fc2bc) 29.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   29.61%   29.49%   -0.13%     
==========================================
  Files          22       22              
  Lines        1651     1624      -27     
==========================================
- Hits          489      479      -10     
+ Misses       1115     1098      -17     
  Partials       47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonyo tonyo merged commit 18eff73 into master Dec 21, 2023
5 checks passed
@tonyo tonyo deleted the tonyo/add-golangci-lint branch December 21, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants