Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eliminate some linting warnings/errors #83

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Jiahui-Zhang-20
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (8f9b884) 30.11% compared to head (6a966d8) 29.93%.

Files Patch % Lines
integrations_gke.go 0.00% 17 Missing ⚠️
crons.go 0.00% 14 Missing ⚠️
enhancers.go 38.46% 8 Missing ⚠️
cluster_config.go 0.00% 5 Missing ⚠️
informers.go 0.00% 4 Missing ⚠️
main.go 0.00% 4 Missing ⚠️
enhancers_common.go 57.14% 2 Missing and 1 partial ⚠️
watcher_events.go 75.00% 2 Missing and 1 partial ⚠️
watcher_pods.go 70.00% 2 Missing and 1 partial ⚠️
informer_cronjobs.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   30.11%   29.93%   -0.18%     
==========================================
  Files          22       22              
  Lines        1624     1640      +16     
==========================================
+ Hits          489      491       +2     
- Misses       1086     1098      +12     
- Partials       49       51       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiahui-Zhang-20 Jiahui-Zhang-20 merged commit 55429ee into master Dec 22, 2023
4 of 6 checks passed
@Jiahui-Zhang-20 Jiahui-Zhang-20 deleted the jz-fix-linting-warnings branch December 22, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants