Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable multiarch build #88

Merged
merged 4 commits into from
Mar 12, 2024
Merged

feat: enable multiarch build #88

merged 4 commits into from
Mar 12, 2024

Conversation

nohant
Copy link
Contributor

@nohant nohant commented Mar 7, 2024

Hello!

by adding the architecture in the GOARCH variable it should be compile faster and work better for the #71

I didn't update the version of the various actions because maybe there is a motive for them to be that specific and I don't know.

Locally i tried TARGETPLATFORM and TARGETARCH

go can compile in arm very fast, it just need to know that.
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.64%. Comparing base (55429ee) to head (8802851).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   31.64%   31.64%           
=======================================
  Files          22       22           
  Lines        1640     1640           
=======================================
  Hits          519      519           
  Misses       1070     1070           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tonyo tonyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion.

Doesn't seem to work in its current form (fails with unsupported GOOS/GOARCH pair linux/linux/amd64 when testing locally), but might work with TARGETARCH.

Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Anton Ovchinnikov <[email protected]>
@nohant
Copy link
Contributor Author

nohant commented Mar 12, 2024

yep I was undecided to which use of the two, better if it works with ARCH

@tonyo
Copy link
Contributor

tonyo commented Mar 12, 2024

Looks like ARG is not needed; also added TARGETPLATFORM, should be good now.

@tonyo tonyo merged commit f154caa into getsentry:master Mar 12, 2024
4 checks passed
@nohant
Copy link
Contributor Author

nohant commented Mar 12, 2024

super good work, thank you mate

@tonyo tonyo mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants