-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable multiarch build #88
Conversation
go can compile in arm very fast, it just need to know that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 31.64% 31.64%
=======================================
Files 22 22
Lines 1640 1640
=======================================
Hits 519 519
Misses 1070 1070
Partials 51 51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion.
Doesn't seem to work in its current form (fails with unsupported GOOS/GOARCH pair linux/linux/amd64
when testing locally), but might work with TARGETARCH.
Co-authored-by: Anton Ovchinnikov <[email protected]>
yep I was undecided to which use of the two, better if it works with ARCH |
Looks like ARG is not needed; also added TARGETPLATFORM, should be good now. |
super good work, thank you mate |
Hello!
by adding the architecture in the GOARCH variable it should be compile faster and work better for the #71
I didn't update the version of the various actions because maybe there is a motive for them to be that specific and I don't know.
Locally i tried
TARGETPLATFORM
andTARGETARCH