fix(openai-provider): only apply reasoning effort to o1/o3 models #635
+20
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix OpenAI provider to only apply the
reasoningEffortparameter to models that support it (o1 and o3 series). Previously, this parameter was applied to all models whenOPENAI_REASONING_EFFORTwas set, which could cause unnecessary overhead or potential errors with non-o1/o3 models like gpt-5.Changes
supportsReasoningEffort()helper function to check if a model supports the reasoning effort parameterselectedModelvariable for better code clarityMotivation
The reasoning effort parameter is specific to OpenAI's o1 and o3 model series. Applying it to other models (like gpt-5, gpt-4, etc.) is unnecessary and could potentially cause issues.
Testing