Skip to content

feat(logs): add (u)int64 sentry_value_t type #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 14, 2025
Merged

feat(logs): add (u)int64 sentry_value_t type #1301

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a0eaaf3
add (u)int64 sentry_value_t type
JoshuaMoelans Jul 3, 2025
118a632
add value_to_msgpack missing switch cases
JoshuaMoelans Jul 4, 2025
bcd93ec
remove undefined behavior test (C99 6.3.1.4)
JoshuaMoelans Jul 4, 2025
8c7983c
avoid Windows sized integer name collision
JoshuaMoelans Jul 4, 2025
b7189eb
cleanup & apply code review feedback
JoshuaMoelans Jul 8, 2025
84fb966
more cleanup & remove type coercion
JoshuaMoelans Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/sentry_value.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ typedef struct {
union {
void *_ptr;
double _double;
int64_t _int64;
uint64_t _uint64;
int64_t _int64_data; // to avoid shadowing __int64 (C2628 error)
uint64_t _uint64_data;
} payload;
long refcount;
uint8_t type;
Expand Down Expand Up @@ -337,7 +337,7 @@ sentry_value_new_int64(int64_t value)
if (!thing) {
return sentry_value_new_null();
}
thing->payload._int64 = value;
thing->payload._int64_data = value;
thing->refcount = 1;
thing->type = (uint8_t)(THING_TYPE_INT64 | THING_TYPE_FROZEN);

Expand All @@ -353,7 +353,7 @@ sentry_value_new_uint64(uint64_t value)
if (!thing) {
return sentry_value_new_null();
}
thing->payload._uint64 = value;
thing->payload._uint64_data = value;
thing->refcount = 1;
thing->type = (uint8_t)(THING_TYPE_UINT64 | THING_TYPE_FROZEN);

Expand Down Expand Up @@ -966,10 +966,10 @@ sentry_value_as_int64(sentry_value_t value)

const thing_t *thing = value_as_thing(value);
if (thing && thing_get_type(thing) == THING_TYPE_INT64) {
return thing->payload._int64;
return thing->payload._int64_data;
}
if (thing && thing_get_type(thing) == THING_TYPE_UINT64) {
return (int64_t)thing->payload._uint64;
return (int64_t)thing->payload._uint64_data;
}
if (thing && thing_get_type(thing) == THING_TYPE_DOUBLE) {
return (int64_t)thing->payload._double;
Expand All @@ -987,10 +987,12 @@ sentry_value_as_uint64(sentry_value_t value)

const thing_t *thing = value_as_thing(value);
if (thing && thing_get_type(thing) == THING_TYPE_UINT64) {
return thing->payload._uint64;
return thing->payload._uint64_data;
}
if (thing && thing_get_type(thing) == THING_TYPE_INT64) {
return thing->payload._int64 >= 0 ? (uint64_t)thing->payload._int64 : 0;
return thing->payload._int64_data >= 0
? (uint64_t)thing->payload._int64_data
: 0;
}
if (thing && thing_get_type(thing) == THING_TYPE_DOUBLE) {
// TODO no check for double out of uint64 range
Expand Down
Loading