Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breadcrumbs): add _meta information for truncation of breadcrumbs #4007

Merged
merged 25 commits into from
Apr 3, 2025

Conversation

shellmayr
Copy link
Member

@shellmayr shellmayr commented Jan 30, 2025

  • Implements annotations for breadcrumbs

  • Adds an int field to Scope to track the number of truncated breadcrumbs

  • When scopes are merged, the number of breadcrumbs that were removed are added

  • If breadcrumbs were truncated, add the original number of breadcrumbs to _meta

  • Closes https://github.com/getsentry/projects/issues/593

@shellmayr shellmayr changed the title feat: add breadcrumb annotationvalue feat(breadcrumbs): add _metatags for truncation of breadcrumbs Jan 30, 2025
@shellmayr shellmayr changed the title feat(breadcrumbs): add _metatags for truncation of breadcrumbs feat(breadcrumbs): add _meta-tags for truncation of breadcrumbs Jan 30, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.56%. Comparing base (5f71872) to head (e9a5e51).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/scope.py 87.50% 0 Missing and 2 partials ⚠️
sentry_sdk/scrubber.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4007      +/-   ##
==========================================
+ Coverage   79.51%   79.56%   +0.04%     
==========================================
  Files         142      142              
  Lines       15876    15894      +18     
  Branches     2716     2721       +5     
==========================================
+ Hits        12624    12646      +22     
+ Misses       2388     2381       -7     
- Partials      864      867       +3     
Files with missing lines Coverage Δ
sentry_sdk/client.py 79.05% <100.00%> (+0.29%) ⬆️
sentry_sdk/scrubber.py 94.44% <0.00%> (ø)
sentry_sdk/scope.py 86.08% <87.50%> (-0.07%) ⬇️

... and 3 files with indirect coverage changes

@shellmayr shellmayr force-pushed the shellmayr/feat/add-breadcrumb-annotationvalue branch from f9d0063 to 06216d8 Compare March 31, 2025 08:08
@shellmayr shellmayr marked this pull request as ready for review March 31, 2025 08:33
@shellmayr shellmayr requested a review from a team as a code owner March 31, 2025 08:33
@shellmayr shellmayr requested a review from constantinius March 31, 2025 08:33
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cleptric given that we want to move towards not truncating any data in SDKs, should we still be implementing this change?

@shellmayr shellmayr requested a review from a team as a code owner April 2, 2025 07:49
@shellmayr shellmayr requested a review from antonpirker April 3, 2025 08:07
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now! @shellmayr please fix the linting errors so this can be merged.

@antonpirker antonpirker changed the title feat(breadcrumbs): add _meta-tags for truncation of breadcrumbs feat(breadcrumbs): add _meta information for truncation of breadcrumbs Apr 3, 2025
@antonpirker antonpirker merged commit 5147ab9 into master Apr 3, 2025
139 checks passed
@antonpirker antonpirker deleted the shellmayr/feat/add-breadcrumb-annotationvalue branch April 3, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants