-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breadcrumbs): add _meta
information for truncation of breadcrumbs
#4007
feat(breadcrumbs): add _meta
information for truncation of breadcrumbs
#4007
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4007 +/- ##
==========================================
+ Coverage 79.51% 79.56% +0.04%
==========================================
Files 142 142
Lines 15876 15894 +18
Branches 2716 2721 +5
==========================================
+ Hits 12624 12646 +22
+ Misses 2388 2381 -7
- Partials 864 867 +3
|
f9d0063
to
06216d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cleptric given that we want to move towards not truncating any data in SDKs, should we still be implementing this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now! @shellmayr please fix the linting errors so this can be merged.
_meta
information for truncation of breadcrumbs
Implements annotations for breadcrumbs
Adds an
int
field toScope
to track the number of truncated breadcrumbsWhen scopes are merged, the number of breadcrumbs that were removed are added
If breadcrumbs were truncated, add the original number of breadcrumbs to
_meta
Closes https://github.com/getsentry/projects/issues/593