-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs): Add alpha version of Sentry logs #4126
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4126 +/- ##
==========================================
+ Coverage 79.52% 79.55% +0.02%
==========================================
Files 140 141 +1
Lines 15636 15711 +75
Branches 2652 2671 +19
==========================================
+ Hits 12435 12499 +64
Misses 2369 2369
- Partials 832 843 +11
|
Any reason we are not taking the same route as JS with this? |
the import is from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok for a first implementation. I added some unit tests to know how it feels to use this new API.
I have added some TODO
comments with topics I think we should discuss.
I we want to parse variables from f-strings here is how other libs do this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding some tests and adding the configuration options also under the _experimental
flag, this is good enough for an alpha version!
Logs are coming to sentry!
This commit:
sentry_sdk._experimental_logger.{trace, debug, info, warn, error, fatal}
methods_experimental
options forbefore_emit_log
andenable_sentry_logs
There are no tests (yet), and this still uses the otel_log schema.
Example usage:
Refs #4149