-
Notifications
You must be signed in to change notification settings - Fork 562
feat(toxgen): Generate TESTPATH
for integrated test suites
#4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TESTPATH
for integrated test suites
❌ 64 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
asgi: TESTPATH=tests/integrations/asgi | ||
aws_lambda: TESTPATH=tests/integrations/aws_lambda | ||
cloud_resource_context: TESTPATH=tests/integrations/cloud_resource_context | ||
gcp: TESTPATH=tests/integrations/gcp | ||
opentelemetry: TESTPATH=tests/integrations/opentelemetry | ||
potel: TESTPATH=tests/integrations/opentelemetry | ||
socket: TESTPATH=tests/integrations/socket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I am wondering if we can auto-generate the TESTPATH
for all integrations? The ones I have highlighted are still explicitly specified in tox.ninja
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are hardcoded since those are tests suites that are not managed by toxgen. But agree that it looks a bit strange. Added at least a small comment e1a547c to clarify the different treatment for future reference.
Description
Make toxgen generate the
TESTPATH
env var for integrated test suites, removing a manual step when adding a new test suite.Issues
Closes #4536
Reminders
tox -e linters
.feat:
,fix:
,ref:
,meta:
)