Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2.5) test: Adds snapshot tests #4379

Merged
merged 101 commits into from
Jan 15, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Dec 16, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds snapshot tests for the defaults, custom texts and custom styles

💡 Motivation and Context

See #4328 (comment)

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

antonis and others added 23 commits December 17, 2024 16:56
* Adds sentry branding logo as a base64 encoded png

---------

Co-authored-by: LucasZF <[email protected]>
Base automatically changed from antonis/3859-newCaptureFeedbackAPI-Form to feedback-ui January 10, 2025 10:32
…rm-Snapshot

# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackForm.tsx
#	packages/core/src/js/index.ts
#	packages/core/test/feedback/FeedbackForm.test.tsx
#	samples/react-native/src/Screens/ErrorsScreen.tsx
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! LGTM!

@antonis antonis merged commit 08eecba into feedback-ui Jan 15, 2025
66 checks passed
@antonis antonis deleted the antonis/3859-newCaptureFeedbackAPI-Form-Snapshot branch January 15, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants