feat: Add RN SDK package to sdk.packages for Cocoa #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
|
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4297324+dirty | 385.33 ms | 435.68 ms | 50.35 ms |
| 52c0562+dirty | 401.23 ms | 435.65 ms | 34.42 ms |
| c398f67+dirty | 315.08 ms | 345.60 ms | 30.52 ms |
| 52a8031+dirty | 330.72 ms | 358.76 ms | 28.03 ms |
| b95b8af+dirty | 392.94 ms | 428.00 ms | 35.06 ms |
| baa882f+dirty | 449.30 ms | 540.40 ms | 91.10 ms |
| 728164b+dirty | 335.93 ms | 342.94 ms | 7.01 ms |
| 70caa60+dirty | 308.83 ms | 393.06 ms | 84.23 ms |
| 1c65324+dirty | 381.10 ms | 427.26 ms | 46.16 ms |
| e1ea4a8+dirty | 451.98 ms | 497.58 ms | 45.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4297324+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 52c0562+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| c398f67+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
| 52a8031+dirty | 7.15 MiB | 8.09 MiB | 965.95 KiB |
| b95b8af+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| baa882f+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| 728164b+dirty | 7.15 MiB | 8.12 MiB | 997.71 KiB |
| 70caa60+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
| 1c65324+dirty | 7.15 MiB | 8.22 MiB | 1.07 MiB |
| e1ea4a8+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
antonis
reviewed
Dec 17, 2024
There was a problem hiding this comment.
The code changes look good to me 🚀
I restrain from approving till getsentry/sentry-cocoa#4637 is shipped with the next Cocoa SDK.
Similar to Android I'm not sure if getting the version from the react native options makes sense.
|
I've added a comment to the code versioning in the Android pr |
# Conflicts: # CHANGELOG.md # scripts/version-bump.js
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f6950b | 438.74 ms | 430.71 ms | -8.03 ms |
| cdf2f33 | 469.46 ms | 462.17 ms | -7.29 ms |
| b6f8ea2 | 472.49 ms | 469.60 ms | -2.89 ms |
| 62a750b | 395.96 ms | 423.36 ms | 27.41 ms |
| abb7058 | 370.27 ms | 389.58 ms | 19.31 ms |
| 4a6664f | 548.79 ms | 585.00 ms | 36.21 ms |
| 52c0562 | 453.04 ms | 434.71 ms | -18.33 ms |
| 8c88ac7 | 411.15 ms | 400.54 ms | -10.60 ms |
| 575f9da | 415.26 ms | 422.98 ms | 7.72 ms |
| 70caa60+dirty | 299.00 ms | 321.02 ms | 22.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7f6950b | 17.74 MiB | 20.10 MiB | 2.36 MiB |
| cdf2f33 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| b6f8ea2 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 62a750b | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| abb7058 | 17.73 MiB | 19.83 MiB | 2.10 MiB |
| 4a6664f | 17.73 MiB | 19.94 MiB | 2.21 MiB |
| 52c0562 | 17.73 MiB | 20.11 MiB | 2.38 MiB |
| 8c88ac7 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 575f9da | 17.73 MiB | 19.83 MiB | 2.10 MiB |
| 70caa60+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c639edf+dirty | 1236.18 ms | 1235.04 ms | -1.14 ms |
| 79976dd+dirty | 1223.65 ms | 1224.16 ms | 0.51 ms |
| abb7058+dirty | 1255.42 ms | 1268.86 ms | 13.44 ms |
| d8e8c67+dirty | 1222.57 ms | 1226.22 ms | 3.65 ms |
| 946a600+dirty | 1238.20 ms | 1236.85 ms | -1.35 ms |
| d43a46b+dirty | 1219.24 ms | 1219.65 ms | 0.41 ms |
| e73f4ed+dirty | 1243.27 ms | 1244.52 ms | 1.25 ms |
| 63ed251+dirty | 1232.55 ms | 1238.77 ms | 6.22 ms |
| 8c88ac7+dirty | 1205.13 ms | 1218.87 ms | 13.74 ms |
| 52a8031+dirty | 1280.88 ms | 1289.78 ms | 8.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c639edf+dirty | 2.36 MiB | 3.08 MiB | 736.63 KiB |
| 79976dd+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| abb7058+dirty | 2.36 MiB | 2.87 MiB | 520.42 KiB |
| d8e8c67+dirty | 2.36 MiB | 3.12 MiB | 779.40 KiB |
| 946a600+dirty | 2.36 MiB | 3.10 MiB | 759.74 KiB |
| d43a46b+dirty | 2.36 MiB | 3.08 MiB | 734.25 KiB |
| e73f4ed+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
| 63ed251+dirty | 2.36 MiB | 3.10 MiB | 752.55 KiB |
| 8c88ac7+dirty | 2.36 MiB | 3.10 MiB | 752.63 KiB |
| 52a8031+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c639edf+dirty | 1223.63 ms | 1227.98 ms | 4.35 ms |
| 79976dd+dirty | 1243.73 ms | 1242.40 ms | -1.34 ms |
| abb7058+dirty | 1260.28 ms | 1266.56 ms | 6.28 ms |
| d8e8c67+dirty | 1235.58 ms | 1233.44 ms | -2.15 ms |
| 946a600+dirty | 1236.12 ms | 1234.94 ms | -1.18 ms |
| d43a46b+dirty | 1223.31 ms | 1230.92 ms | 7.61 ms |
| e73f4ed+dirty | 1282.90 ms | 1309.30 ms | 26.40 ms |
| 63ed251+dirty | 1223.27 ms | 1222.94 ms | -0.33 ms |
| 8c88ac7+dirty | 1240.66 ms | 1247.42 ms | 6.76 ms |
| 52a8031+dirty | 1255.96 ms | 1273.00 ms | 17.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c639edf+dirty | 2.92 MiB | 3.64 MiB | 742.55 KiB |
| 79976dd+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| abb7058+dirty | 2.92 MiB | 3.43 MiB | 524.53 KiB |
| d8e8c67+dirty | 2.92 MiB | 3.69 MiB | 790.53 KiB |
| 946a600+dirty | 2.92 MiB | 3.67 MiB | 772.40 KiB |
| d43a46b+dirty | 2.92 MiB | 3.64 MiB | 740.29 KiB |
| e73f4ed+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
| 63ed251+dirty | 2.92 MiB | 3.66 MiB | 757.10 KiB |
| 8c88ac7+dirty | 2.92 MiB | 3.66 MiB | 757.12 KiB |
| 52a8031+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
antonis
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
LGTM 🚀
Note: I took the liberty of merging main and pushing a couple of minor fixes (one, two) since the Cocoa/Android dependencies were resolved and 6.5.0 release was being prepared.
| @@ -15,6 +15,7 @@ | |||
| ### Changes | |||
|
|
|||
| - Rename `navigation.processing` span to more expressive `Navigation dispatch to screen A mounted/navigation cancelled` ([#4423](https://github.com/getsentry/sentry-react-native/pull/4423)) | |||
| - Add RN SDK package to `sdk.packages` for Cocoa ([#4381](https://github.com/getsentry/sentry-react-native/pull/4381)) | |||
There was a problem hiding this comment.
@krystofwoldrich We should also move the Android change to Changes too.
There was a problem hiding this comment.
The android change was already released in 6.5.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR adds react native sdk package name and version to cocoa sdk packages.
This helps identify the exact version of rn sdk producing session replay.
This PR needs update of SentryCocoa with getsentry/sentry-cocoa#4637
💡 Motivation and Context
This help with debugging rn session replays.
💚 How did you test it?
sample app
📝 Checklist
sendDefaultPIIis enabled