-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Session Replay is GA #4384
base: main
Are you sure you want to change the base?
Conversation
|
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f6950b+dirty | 1235.53 ms | 1227.30 ms | -8.23 ms |
31fcca2+dirty | 1209.17 ms | 1216.21 ms | 7.04 ms |
8e80789+dirty | 1228.04 ms | 1237.20 ms | 9.16 ms |
3ffcddd+dirty | 1244.47 ms | 1264.14 ms | 19.67 ms |
a5d86e1+dirty | 1242.47 ms | 1239.94 ms | -2.53 ms |
52a8031+dirty | 1280.88 ms | 1289.78 ms | 8.90 ms |
70caa60+dirty | 1218.27 ms | 1230.30 ms | 12.03 ms |
27ef4ee+dirty | 1293.52 ms | 1296.08 ms | 2.56 ms |
ddc0552+dirty | 1236.13 ms | 1248.17 ms | 12.05 ms |
8ae23a7+dirty | 1230.02 ms | 1227.62 ms | -2.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f6950b+dirty | 2.36 MiB | 3.11 MiB | 760.04 KiB |
31fcca2+dirty | 2.36 MiB | 2.90 MiB | 552.95 KiB |
8e80789+dirty | 2.36 MiB | 3.10 MiB | 759.43 KiB |
3ffcddd+dirty | 2.36 MiB | 2.84 MiB | 489.60 KiB |
a5d86e1+dirty | 2.36 MiB | 3.10 MiB | 752.65 KiB |
52a8031+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
70caa60+dirty | 2.36 MiB | 2.83 MiB | 479.27 KiB |
27ef4ee+dirty | 2.36 MiB | 2.85 MiB | 500.03 KiB |
ddc0552+dirty | 2.36 MiB | 3.11 MiB | 759.84 KiB |
8ae23a7+dirty | 2.36 MiB | 3.10 MiB | 752.42 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f6950b+dirty | 1250.94 ms | 1252.92 ms | 1.98 ms |
31fcca2+dirty | 1222.04 ms | 1226.51 ms | 4.47 ms |
8e80789+dirty | 1235.66 ms | 1223.78 ms | -11.88 ms |
3ffcddd+dirty | 1272.22 ms | 1273.98 ms | 1.76 ms |
a5d86e1+dirty | 1230.35 ms | 1222.47 ms | -7.88 ms |
52a8031+dirty | 1255.96 ms | 1273.00 ms | 17.04 ms |
70caa60+dirty | 1279.08 ms | 1281.54 ms | 2.46 ms |
27ef4ee+dirty | 1236.41 ms | 1244.90 ms | 8.49 ms |
ddc0552+dirty | 1246.00 ms | 1241.98 ms | -4.02 ms |
8ae23a7+dirty | 1233.67 ms | 1229.52 ms | -4.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7f6950b+dirty | 2.92 MiB | 3.67 MiB | 772.53 KiB |
31fcca2+dirty | 2.92 MiB | 3.46 MiB | 557.31 KiB |
8e80789+dirty | 2.92 MiB | 3.67 MiB | 772.00 KiB |
3ffcddd+dirty | 2.92 MiB | 3.40 MiB | 494.39 KiB |
a5d86e1+dirty | 2.92 MiB | 3.66 MiB | 757.10 KiB |
52a8031+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
70caa60+dirty | 2.92 MiB | 3.39 MiB | 486.04 KiB |
27ef4ee+dirty | 2.92 MiB | 3.41 MiB | 503.72 KiB |
ddc0552+dirty | 2.92 MiB | 3.67 MiB | 772.47 KiB |
8ae23a7+dirty | 2.92 MiB | 3.66 MiB | 757.67 KiB |
packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for deprecating _experiments for SR 🙇
The changes on this PR LGTM 🚀
I restrain from approving till the Cocoa and Android SDKs land and I can fully test the changes.
NIT: also found a few more places that we may want to update:
…entryReplayOptionsTests.swift Co-authored-by: Antonis Lilis <[email protected]>
Co-authored-by: GitHub <[email protected]> Co-authored-by: Roman Zavarnitsyn <[email protected]>
Co-authored-by: GitHub <[email protected]> Co-authored-by: Roman Zavarnitsyn <[email protected]>
@antonis I've updated the native SDKs and also adjusted the code to make it compiling. Also addressed your nit about the leftovers that use the deprecated options. Could you PTAL once more? All build failures look like a flake to me. Here's also a relevant Android replay from this branch: https://sentry-sdks.sentry.io/replays/86ec775d2df04b21bd6c4af47478556d/?project=5428561&query=&referrer=%2Freplays%2F%3AreplaySlug%2F&statsPeriod=1h&t_main=tags&yAxis=count%28%29&t=0 I don't have the latest ios simulator, so if you could test it on iOS that would be great! |
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
9c48b2c | 349.24 ms | 385.96 ms | 36.72 ms |
d43a46b | 454.22 ms | 477.79 ms | 23.57 ms |
8ab11b6 | 462.10 ms | 450.40 ms | -11.70 ms |
0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
62a750b | 395.96 ms | 423.36 ms | 27.41 ms |
0d3e677 | 422.82 ms | 411.90 ms | -10.92 ms |
1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
1332acb | 493.40 ms | 475.20 ms | -18.21 ms |
9282172 | 486.12 ms | 467.70 ms | -18.42 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
9c48b2c | 17.73 MiB | 19.80 MiB | 2.07 MiB |
d43a46b | 17.73 MiB | 20.06 MiB | 2.33 MiB |
8ab11b6 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
62a750b | 17.73 MiB | 19.93 MiB | 2.20 MiB |
0d3e677 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
1332acb | 17.74 MiB | 20.09 MiB | 2.35 MiB |
9282172 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thank you for your work on this @krystofwoldrich and for helping move this forward @romtsn 🙇
I took the liberty of pushing a minor test fix with c12f51e
🛑 Requires
📜 Description
This PR adds SR GA changelog entry and deprecates
_experiments
options which will be removed in the next major version.(I choose to deprecate options in
_experiments
and not to remove them, as with removal the SR would silently stop working for our beta users.)This PR updates the native implementation to use GA options of Sentry Cocoa and Android.
💚 How did you test it?
updated tests, native implementation is waiting for the native SDKs update
📝 Checklist
sendDefaultPII
is enabled